Skip to content

fix: allow dots in markdown link text#8596

Merged
mejo- merged 1 commit into
nextcloud:mainfrom
SSDWGG:fix/markdown-link-text-dots
May 20, 2026
Merged

fix: allow dots in markdown link text#8596
mejo- merged 1 commit into
nextcloud:mainfrom
SSDWGG:fix/markdown-link-text-dots

Conversation

@SSDWGG
Copy link
Copy Markdown
Contributor

@SSDWGG SSDWGG commented May 16, 2026

Summary

  • loosen the markdown link input rule so link text can contain dots
  • add a regression test for [something.cloud](https://something.cloud/page)

Fixes #7872

Tests

  • npx vitest run src/tests/marks/Link.spec.js

@mejo- mejo- force-pushed the fix/markdown-link-text-dots branch from 35b85e0 to 9bd164e Compare May 18, 2026 13:19
@mejo-
Copy link
Copy Markdown
Member

mejo- commented May 18, 2026

Thanks @SSDWGG, much appreciated. I slightly adjusted your commit and added a Playwright test to have end-to-end testing of the input rule.

@mejo- mejo- self-assigned this May 18, 2026
@mejo-
Copy link
Copy Markdown
Member

mejo- commented May 18, 2026

/backport to stable34

@mejo-
Copy link
Copy Markdown
Member

mejo- commented May 18, 2026

/backport to stable33

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/markdown-link-text-dots branch from 9bd164e to ae3f8dd Compare May 18, 2026 14:12
@mejo- mejo- merged commit 658a741 into nextcloud:main May 20, 2026
82 of 89 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating links in Nextcloud Notes using md syntax does not always work.

2 participants