Remove PHP and Nextcloud upper version constraints #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove PHP and Nextcloud version constraints. Nextcloud releases come out every 3 months. Currently, no known issue requires forbidding the usage with the latest release. - Later on, if a serious change is required, then we can temporarily forbid the deployment. Signed-off-by: cociweb <cociweb@users.noreply.github.com>
cociweb
changed the title
Contributor
Author
|
Currently there is a bug in nextcloud xsd schema, where the max-version seems to be mandatory instead of the docs: |
Currently there is a bug in nextcloud xsd schema, where the max-version seems to be mandatory instead of the docs: nextcloud/server#56487 so until that, a workaround can be applied as max-version="99" instead of fully remove it Signed-off-by: cociweb <cociweb@users.noreply.github.com>
Member
Hey, thanks for taking the time 😊 Regarding the max Nextcloud version, this won't work I think. The AppStore isn't designed to support this. There is already the option to force enable, that should be enough 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PHP and Nextcloud upper version constraints. Nextcloud releases come out every 3 months. Currently, no known compatibility issue requires forbidding the usage with the latest (and future) releases.
This PR should resolve nextcloud/server#169 nextcloud/server#170 and similar issues going forward.
and close as a duplicate solution only for the NC32 release: nextcloud/server#171
@skjnldsv or @joshtrichards : What is your opinion?