fix: prevent wheel events in embeds propagating to parent #903
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
benjaminfrueh
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
hweihwang
force-pushed
the
fix/embed-wheel-propagation
branch
from
1040c89 to
d8d1586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When scrolling or zooming inside an embedded element, the wheel events would propagate to the parent, causing both the embed and the parent to zoom/pan simultaneously.
Solution
Attached wheel event listeners to each embed container that call
stopPropagation()to prevent events propagating to the parent.