fix(admin): persist Draft/Published status to ui-schema.json on edit#82
Merged
Merged
Conversation
The collection/single edit builders dropped the `status` flag when writing ui-schema.json: the field-change path omitted it from the manifest settings and the settings-only path never wrote the file at all. As a result migrate:create (which builds UI-built entities' desired snapshot solely from ui-schema.json) never saw Draft/Published and omitted the `status` column, drifting generated migrations from the live DB. Add a shared `settings-to-manifest` adapter that always forwards `status` (explicit true/false so it can be turned off), and call it from both save paths in both edit pages. Document the dev-write full-replace contract and pin it (plus the UI status-forwarding) with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collection/single edit builders dropped the
statusflag when writing ui-schema.json: the field-change path omitted it from the manifest settings and the settings-only path never wrote the file at all. As a result migrate:create (which builds UI-built entities' desired snapshot solely from ui-schema.json) never saw Draft/Published and omitted thestatuscolumn, drifting generated migrations from the live DB.Add a shared
settings-to-manifestadapter that always forwardsstatus(explicit true/false so it can be turned off), and call it from both save paths in both edit pages. Document the dev-write full-replace contract and pin it (plus the UI status-forwarding) with regression tests.Summary
Type of change
Related issues
Changeset
This repo uses Changesets. If your PR changes any publishable package under
packages/*, you must include a changeset:Then commit the generated
.changeset/*.mdfile.apps/*)Test plan
pnpm lintpnpm check-typespnpm buildChecklist
mainbranchScreenshots / recordings
Notes for reviewers