Conversation
Contributor
|
@niravshah241 thanks for drafting this PR. I know that it is draft stage but draft PRs still shouldn't contain CMake build files. Please remove these as discussed last meeting. Please only commit changes for relevant source files. |
TomMelt
reviewed
Oct 20, 2025
TomMelt
reviewed
Oct 20, 2025
TomMelt
reviewed
Oct 20, 2025
TomMelt
reviewed
Oct 20, 2025
TomMelt
reviewed
Oct 20, 2025
added 14 commits
October 23, 2025 19:37
…pdated to corner_neighbour
…inghbour logic in discover_neighbours
TomMelt
reviewed
Nov 3, 2025
Contributor
There was a problem hiding this comment.
@niravshah241 as a rule, I would generally just remove this change. It's just formatting. Unless it's required by the linter (which I dont think it is).
…c neighbour tests in integration still need to be fixed, More tests test_3 and test_4 added for corner neighbours, test_1 and test_2 reference files updated to include details on corner neighbour
Author
|
Pending tasks:
|
TomMelt
reviewed
Nov 10, 2025
* update tests to work with main branch * update Partitioner to use new halo_send/recv approach for edges
…rt, is_neighbour, is_corner_neighbour public members (which were private members earlier)
remove neighbour check logic from domain_overlap update comments in is_neighbour to reflect the changes in Partitioner we still check the halo_size is non-zero but this will always be true, so it is not a problem.
Co-authored-by: Joe Wallwork <22053413+joewallwork@users.noreply.github.com>
Contributor
|
This PR has merged the following PRs: It now contains all the functionality required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the domain is divided across different MPI ranks, the rank corresponding to the neighbour of a given subdomain in a given direction needs to be identified. Currently the functionality is implemented to identify neighbours in TOP, RIGHT, BOTTOM and LEFT direction which share a common edge with the given subdomain. This Draft PR aims to add functionality to identify neighbours in TOP_RIGHT, BOTTOM_RIGHT, BOTTOM_LEFT and TOP_LEFT corners.
Specifically, the changes include:
This PR has merged the following PRs:
It now contains all the functionality required.