Open
Conversation
eee05e2 to
5477258
Compare
timspainNERSC
requested changes
Feb 11, 2026
Collaborator
timspainNERSC
left a comment
There was a problem hiding this comment.
Good that the logging is finally getting looked at!
The CMake formatter has made a mess of the layout of one comment. The rest looks fine, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved log formatting
Fixes #1039
Change Description
Logged messages now also display current local time and the severity level. This is implemented using standard
boost::logcustomization points inLogged::configure. Thus, improved formatting is not used in some tests (like the one referenced in the issue) whereModel::configureis not called.Test Description
I run some cases with a verbose log level, e.g.: