Skip to content

Comments

Halo add pb test for halo exchange#1044

Draft
TomMelt wants to merge 2 commits intohalo-add-cornersfrom
halo-add-PB-test
Draft

Halo add pb test for halo exchange#1044
TomMelt wants to merge 2 commits intohalo-add-cornersfrom
halo-add-PB-test

Conversation

@TomMelt
Copy link
Contributor

@TomMelt TomMelt commented Feb 16, 2026

Add periodic boundary test for Halo Exchange

Task List

  • Linked an issue above that captures the requirements of this PR
  • Defined the tests that specify a complete and functioning change
  • Implemented the source code change that satisfies the tests
  • Commented all code so that it can be understood without additional context
  • No new warnings are generated or they are mentioned below
  • The documentation has been updated (or an issue has been created to do so)
  • Relevant labels (e.g., enhancement, bug) have been applied to this PR
  • This change conforms to the conventions described in the README

Change Description

  • Adds a test for halo exchange with periodic boundaries

Test Description

HaloExchangePB_test.cpp

HaloExchangePB_test.cpp is based on HaloExchangeCB_test.cpp. It creates test data for all the array types:

  • HField
  • VertexField
  • DGField
  • DGVector
  • CGVector

They are created in such a way that the value of each cell can be calculated based on its indices. Therefore we can check after exchange that all of the cells have been exchanged successfully.

This would be a good PR for @niravshah241 to take over.

@TomMelt TomMelt added the enhancement New feature or request label Feb 16, 2026
@TomMelt TomMelt self-assigned this Feb 16, 2026
@TomMelt TomMelt mentioned this pull request Feb 16, 2026
8 tasks
@TomMelt TomMelt changed the title Halo add pb test Halo add pb test for halo exchange Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants