Conversation
Replaces the incorrect handling of Dirichlet boundaries in reinitnormalvelocity(). This could help improving the stability of the model, as I've seen some strange boundary behaviour before.
Member
Author
|
@winzerle This is the code from you we were discussing the other day. My description above is very short - but maybe it's enough? Please feel free to edit it if you'd like. |
Member
Author
|
Superceded by #797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Task List
Change Description
Replaces the incorrect handling of Dirichlet boundaries in reinitnormalvelocity(). This could help improve the stability of the model, as I've seen some strange boundary behaviour before.
Test Description
Standard tests run.
Documentation Impact
N/A
Other Details
None
Pre-Request Checklist