Open
Conversation
einola
approved these changes
Oct 17, 2025
Member
einola
left a comment
einola
left a comment
There was a problem hiding this comment.
Looks fine to me. Just a bit of cleaning of commented out code needed.
Comment on lines
-13
to
+17
| static const std::map<std::string, std::pair<ModelArray::Type, double>> defaultFields = {}; | ||
| static const std::map<std::string, std::pair<ModelArray::Type, double>> defaultFields = { | ||
| // { stress11Name, { ModelArray::Type::DG, 0. } }, | ||
| // { stress12Name, { ModelArray::Type::DG, 0. } }, | ||
| // { stress22Name, { ModelArray::Type::DG, 0. } }, | ||
| }; |
Member
There was a problem hiding this comment.
I guess this should be reverted?
Comment on lines
+160
to
+165
| // } else if (name == stress11Name) { | ||
| // DGModelArray::ma2dg(data, s11); | ||
| // } else if (name == stress12Name) { | ||
| // DGModelArray::ma2dg(data, s12); | ||
| // } else if (name == stress22Name) { | ||
| // DGModelArray::ma2dg(data, s22); |
Comment on lines
+60
to
+65
| // e11.resize_by_mesh(*smesh); | ||
| // e12.resize_by_mesh(*smesh); | ||
| // e22.resize_by_mesh(*smesh); | ||
| // s11.resize_by_mesh(*smesh); | ||
| // s12.resize_by_mesh(*smesh); | ||
| // s22.resize_by_mesh(*smesh); |
Comment on lines
+68
to
+73
| // e11.zero(); | ||
| // e12.zero(); | ||
| // e22.zero(); | ||
| // s11.zero(); | ||
| // s12.zero(); | ||
| // s22.zero(); |
Comment on lines
+201
to
+203
| // DGVector<DGstress> e11, e12, e22; | ||
| // DGVector<DGstress> /*s11,*/ s12, s22; | ||
| // DGVectorHolder<DGstress> s11, s12, s22; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stress restart
Fixes #779
Change Description
Move the stress and strain arrays to the lowest possible point in the class hierarchy. It turns out that this is
CGDynamicsKernel, only one level lower thanDynamicsKernel.Convert the stress arrays to
DGVectorHolders to allow data to be passed around without copying.Test Description
Manually check that valid stress values occur in the restart file after a run length of 0.