Accept Eigen version 5 as well as 3.4.x.#985
Open
timspainNERSC wants to merge 2 commits intodevelopfrom
Open
Conversation
timspainNERSC
force-pushed
the
issue984_maceigenversion
branch
from
6dc657a to
d288d54
Compare
TomMelt
added a commit
that referenced
this pull request
Nov 11, 2025
Fix failing mac build for now. When #985 is ready, we can use that instead.
TomMelt
pushed a commit
that referenced
this pull request
Jan 5, 2026
# Fix usage of Eigen's min and max Fixes #985 ### Task List - [x] Defined the tests that specify a complete and functioning change (*It may help to create a [design specification & test specification](../../../wiki/Specification-Template)*) - [x] Implemented the source code change that satisfies the tests - [x] Documented the feature by providing worked example - [x] Updated the README or other documentation - [x] Completed the pre-Request checklist below --- # Change Description The code stopped compiling when Eigen went from version 3.4.0 to 3.4.1. For some reason, which I don't fully understand, then we can't use ``.array().max()`` or ``.array().min()`` with LocalEdgeVector objects, but using ``cwiseMax().array()`` and ``cwiseMin().array()`` is fine. --- # Test Description The model compiles, and all tests run. I've also run longer test runs, and they seem fine. --- # Documentation Impact None --- # Other Details N/A --- ### Pre-Request Checklist - [x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR - [x] No new warnings are generated - [x] The documentation has been updated (or an issue has been created to track the corresponding change) - [x] Methods and Tests are commented such that they can be understood without having to obtain additional context - [x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change - [x] This change conforms to the conventions described in the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Fixes #984
Change Description
Broadens the valid versions of Eigen to include 5.x.y. The search range syntax is great for this, but only supported in Eigen 3.4.1, and I have 3.4.0, so this also needs to be supported.