Repository navigation
[OPEND-4849] feat(motion): attribute installs through optional campaign links - #263
open-design-crew[bot] wants to merge 5 commits into
Conversation
|
@app/open-design-crew I'm holding off on generating review comments for #263 because this pull request has merge conflicts right now. Please resolve the conflicts with feature/motion and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos. |
The tracked-source scan rejects full internal URLs, so the new attribution doc and the eleven-locale prompt assertion failed the standalone job. Keep the deployment entry as a bare hostname like the other docs, and assert the setup URL with the regex form already used for the same host in this file. Validation: gitleaks source scan passed (3349 files); release-scan, release-workflows, registry-download and stable-release tests passed (35); tests/catalog.test.ts passed (7); npm run check and typecheck:studio passed. Generated-By: looper 0.16.2 (runner=fixer, agent=pi)
PerishCode
left a comment
There was a problem hiding this comment.
The review found two installation compatibility and rollout issues that should be resolved before merging, plus a command-generation edge case. All 16 changed files were reviewed. The 58 focused tests, two selected packaging checks, repository checks, Studio typecheck/build, tracking compilation and diff whitespace check passed on the CI-pinned Node version. Browser, target-machine installation and external-service acceptance suites were not run. The initial pnpm preparation failed because this standalone npm repository has no pnpm lockfile; validation reused the existing npm dependencies.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
…nabled entry - Read the sealed installer from the candidate archive and drop the support marker when that exact installer does not accept --utm-source, so a guide built for an older integrated source never hands setup an unsupported flag. - Keep prod template prompts on the existing R2 installation guide until the production website entry is activated and verified; only the enabled test entry moves to its environment host. - Bind the injected campaign source with `=` so allowlisted values that start with a hyphen remain one option value. Generated-By: looper 0.16.2 (runner=fixer, agent=pi)
|
Looper fixer round complete — 6509ce2
🔁 Powered by Looper · runner=fixer · agent=pi · An autonomous AI dev team for your GitHub repos. |
PerishCode
left a comment
There was a problem hiding this comment.
@app/open-design-crew The repair pass verifies all three previous findings: guide capability now follows the sealed installer, production prompts retain the active R2 guide, and leading-hyphen sources remain valid CLI values. I reviewed the nine-file delta since the previous reviewed head and its directly affected contracts and tests; no actionable findings remain in that scope. Thanks for the focused fixes and regression coverage.
On the CI-pinned Node version, 32 focused tests, repository checks, Studio typechecking/build, documentation links and diff whitespace checks passed. Dependency preparation used npm ci after the requested frozen pnpm install found no pnpm lockfile. The packaging checks passed after Studio build completed; their earlier attempt lacked that build output. GitHub reports no checks for this head. Browser, target-machine installation and external-service acceptance were not run.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.|
@app/open-design-crew I'm holding off on generating review comments for #263 because this pull request has merge conflicts right now. Please resolve the conflicts with feature/motion and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. |
|
@app/open-design-crew I'm holding off on generating review comments for #263 because this pull request has merge conflicts right now. Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos. |
|
What this change does: Adds optional install-source attribution and a read-only installation-guide Worker. Integration blocker: a local three-way merge against main I inspected source validation, shell-safe option formatting and attribution privacy. No additional source defect is confirmed in that inspected scope. Resolve installer/distribution/tracking changes together. Preserve newer source-install guidance and the repository-template prompt path; verify the guide and installer agree on the optional flag without publishing or deploying the Worker as part of this review. Verdict: Resolve the integration blocker and review/test the resulting head before merging. Reviewed head |
|
What this change does: Adds optional install-source attribution and a read-only installation-guide Worker. Follow-up review: the head is unchanged from the previous review. This pass rechecks applicability and integration against current main rather than repeating an unchanged full source review. The current head still conflicts with main in Verdict: Resolve the current integration conflict and review/test the resulting head before approval. No current-head CI checks are reported yet. Reviewed head |
qd1993102
left a comment
There was a problem hiding this comment.
@app/open-design-crew — reviewed the install-attribution change end to end: installer --utm-source handling, identity persistence, the tracking sender/registry wiring, guide generation, the new install-guide Worker, and the docs. One blocking issue: two studio tests embed the internal test host with a scheme, which the tracked-source scan rejects, so the PR's own standalone job fails at the scan step. One non-blocking note asks for a single assertion that the new installation_result event actually reaches the sender. Details inline.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
| expect(clipboard).toHaveBeenCalledOnce(); | ||
| expect(clipboard.mock.calls[0][0]).toContain('指定模板:Reference(hf-moment-M953)'); | ||
| expect(clipboard.mock.calls[0][0]).toContain('https://releases.open-design.ai/open-motion/dev/install.md'); | ||
| expect(clipboard.mock.calls[0][0]).toContain('https://open-design.powerformer.net/motion/install.md'); |
There was a problem hiding this comment.
[P1] Keep the internal test host out of tracked test literals
.github/scripts/motion-scan.mjs flags any tracked file containing a URL whose host is powerformer.net as rule internal-link; only prism-templates.ts gets a rewrite exemption. I ran its privacyFindings over the full git ls-files tree at 6509ce2: exactly two files report internal-link — this line and studio/src/motion/TemplateLibraryDialog.test.tsx:52 — both added by this commit, while the base commit scanned clean. That makes the standalone CI job fail at "Scan tracked source and test release controls without publication credentials", and it would reject the candidate source scan too, even though every behavioral test here passes.
Fix by never spelling the scheme plus domain in test code: export the dev guide URL from shared/integration.ts (the bare open-design.powerformer.net constant there already passes the scan) and assert with expect(prompt).toContain(devInstallGuideUrl), or keep the regex form that commit 1277b6a used in tests/catalog.test.ts.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
| if (trackingLocked() || !trackingPreference(directory)) return; | ||
| await saveInstallationSource(path.join(directory, 'tracking'), source); | ||
| const tracking = await createAppTracking(directory, 'installer'); | ||
| tracking.track('installation_result', { outcome: 'success', host_product: host }); |
There was a problem hiding this comment.
[P2] Assert that the installation_result event actually reaches the sender
recordInstallation discards the return value of tracking.track(...), so a registry mistake — a renamed required field, a host value missing from the host_product enum, a wrong entrypoint — silently yields 'invalid' and zero reports while every test stays green: the installer fixture replaces shared/tracking.ts with a stub (tests/npm-installer.test.ts:41), and the new tests/tracking.test.ts case only exercises saveInstallationSource. Because docs/install-attribution.md defines the installation and project metrics from these events, a wiring regression would look identical to "no installations".
Add one test that drives recordInstallation against the real createNodeTracking/createPosthogSender with a capture fetch (the pattern already used in tests/tracking.test.ts) and asserts the emitted installation_result carries outcome, host_product, installation_id and the saved od_utm_source, or at minimum assert track() returns 'queued'.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
|
Heads-up: PR #638 is also open for the same campaign-linked install attribution work, with overlapping installer, tracking, Worker, and regression-test files. Since both PRs are from the same contributor, would you like to consolidate them into one current branch? The maintainer team can then review a single integration result. |
Problem and behavior
Campaign links currently lose their source when users install OpenMotion. Add optional
setup --utm-sourceattribution, retaining the existing installation identity and saved source on untagged upgrades. Successful setup and subsequent domain events exposeod_utm_source; existing telemetry opt-outs remain effective.An R2-backed Worker annotates setup commands only when the published guide declares support. Untagged requests and older guides retain their commands. The Worker is deployed on its independent workers.dev endpoint; the test website route open-design.powerformer.net/motion/install.md is now enabled. Production routes remain disabled and no npm version was published by this change.
Validation
Rollout
Publish a supporting installer to enable parameter injection on the existing test entry. Verify and activate the production website route separately. Immutable guides and other release resources remain on R2. See docs/install-attribution.md. Companion landing branch: feat/motion-install-attribution in core/od-landing.