Repository navigation
Connect Explore, media scenes and studios in the creative workspace - #637
Conversation
|
@qd1993102 Please review |
qd1993102
left a comment
There was a problem hiding this comment.
@pftom Thanks for the substantial Explore and creative-studio navigation work. I reviewed the seeded d7527cac...f25c2f1c diff, traced the shared studio catalogue, URL/history flows and asset routes, and ran the focused deterministic checks for short-form discovery, MCP onboarding, npm installation and design tokens; those passed. Two items need attention before merge: one packaged audio asset is outside the distribution walk, and six new studio/MCP strings are not localized outside Chinese. Details are inline.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
|
@qd1993102 Both findings are fixed on |
|
@pftom I'm holding off on generating review comments for #637 because this pull request has merge conflicts right now. Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos. |
|
@qd1993102 The conflicts with Both inline findings have regression coverage. The application and plugin packages include the Vite-emitted soundtrack. I also fixed the Studio title rendering and search so users can find the same destination by its English or translated name. Chrome displayed the three localized Studio titles and credited-template guidance in all ten translated locales. The production build, type checks, package tests and focused Studio tests pass. |
|
The latest changes touch user-facing Studio navigation, Explore playback, scene/model selection, workspace routing, and packaged media. I’ve marked this PR for validation so those flows get a focused pass once the branch is merge-ready. |
qd1993102
left a comment
There was a problem hiding this comment.
Reviewed the repair-frontier delta from f25c2f1c to 76b30d48 (44 files): the template-detail handoff that composes guarded session/artifact preparation with exact-request reconciliation, the same-dialog motion guide with its sandboxed escape bridge, the related-template masonry shelf with a two-player budget, the new tracking events, and the localized Studio entry points and searchable destination names.
What I traced and checked:
prepareTemplateProject/preparedFromCatalogagainstserver.tscreateSession,createArtifactandopenProject(scoped store revisions,expectedProjectId, acknowledged empty session reuse, and the trashed-project fallback).- The typed create/reconcile/open outcomes in
TemplateLibraryDialogagainst the documented semantics intracking/README.md, including no duplicate creation after a lost response and the same request id on retry. template_project_result,ui_clickdetail actions, related-card impressions and the newsurface_viewareas for field validity againsttracking/events.tsandtracking/core.ts.- The new vitest and browser coverage for retry, unknown results, stale selection, guide Escape and related-card playback; CI is green on this head.
I did not re-run the suite locally because this worktree has no installed dependencies, so verification here is static reading plus the green CI signal.
Genuinely nice work on the ambiguous-creation path: keeping the exact request identity, separating create from reconcile and open, and refusing a second copy after an unclear response is the hard part of this flow, and the tests document it well. The related shelf reusing the gallery cards instead of a second card recipe also keeps the library coherent. Thanks for the careful, well-tested iteration.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
|
Hey @pftom — the branch is merge-ready and the earlier fixes are covered by green CI. We’ve requested @AmyShang-alt for a focused QA pass on the Explore/Studio navigation and history flows, scene/model handoff, preview playback, and packaged media paths. Once QA confirms those paths on this head, we’ll have the final validation signal. |
|
@qd1993102 Please re-review @AmyShang-alt The assigned QA pass can use this head. The focused Studio tests cover Explore → Studio → browser Back/Forward, scene and model selection, and template previews. All 84 passed locally, along with 59 installer, attribution, MCP and discovery tests and nine distribution tests, including the packaged soundtrack check. The Studio production build and type check also passed. |
qd1993102
left a comment
There was a problem hiding this comment.
@pftom Thanks for folding main into this branch and keeping both sides of the conflict intact.
Repair-frontier review (previously reviewed head 76b30d48 → d2e51e53): only three files were touched by both this PR and #638, and each resolution is a proper union.
scripts/distribution.tskeeps them4aextension forstudio/build(needed by thesoundtrack.m4a?urlimport insceneShowcase.ts) alongside main'sdocs/install-attribution.mdandshared/install-attribution.tsentries.tests/npm-installer.test.tskeepsshared/studio-catalog.tsin the fixture, whichshared/workspace-url.tsimports, while main's tracking fixture files and the attribution upgrade test are present unchanged.tracking/events.tskeepsapp_headerinmcpEntryand main'sinstallation_started/installation_resultevents; theapp_headervalue matches the emitter inWorkspaceFrame.tsx.
The merge adds main's 14 changed files and alters nothing else relative to the prior PR head, there are no conflict markers, and all 15 checks are green. The union resolution here is easy to get subtly wrong, and this one preserves both the Studio catalog wiring and the install-attribution flow cleanly. Nice work.
🔁 Powered by Looper · runner=reviewer · agent=omp · An autonomous AI dev team for your GitHub repos.
Why
Creators need a direct route from a motion example, scene, template or model to the editor or generator that can use it.
What changed
Validation
The Studio suite passed 9,926 tests on
76b30d48(16 todo, one file skipped). Source and design checks, Studio type checking, production builds and the nine distribution tests passed. The installer, MCP onboarding, short-form discovery and review-comment suites were also exercised during this PR.Chrome verified responsive generator controls, carousel geometry, gallery ordering, project-scoped MCP handoff and review comments. Template previews passed in both themes at 640 × 360, 390 × 844 and 1440 × 900, including Retry, Escape and the player budget after integrating
main. Studio titles and credited-template guidance rendered in all ten translated locales. The packaged application served the bundled soundtrack asaudio/mp4and Chrome played it. The transcript and platform export browser workflows also passed during this PR.After integrating the installer attribution changes on
d2e51e53, the focused suites passed 84 Studio tests and 68 installer, attribution, MCP, discovery and distribution tests. A Chrome run played the first Explore preview, observed an automatic slide change, opened Codex Image from the Image menu and restored the text-to-image workspace and model through browser Back and Forward. The new npm application archive contains both the Studio catalog and the install attribution module. Its 469,789-byte soundtrack matches the production build byte for byte.Review focus
Please check browser Back and Forward across Explore, the native editor and generation forms, model compatibility when changing scenes, and playback and layout at narrow widths.