refactor posfile transformation for quilt and stitch#268
Open
atrigila wants to merge 5 commits intonf-core:devfrom
Open
refactor posfile transformation for quilt and stitch#268atrigila wants to merge 5 commits intonf-core:devfrom
atrigila wants to merge 5 commits intonf-core:devfrom
Conversation
Collaborator
atrigila
commented
Mar 15, 2026
atrigila
commented
- Refactor duplicated posfile preprocessing for STITCH and QUILT into a single module.
- Run the transform once and reuse the tabular posfile for both imputation tools.
LouisLeNezet
requested changes
Mar 16, 2026
Collaborator
There was a problem hiding this comment.
Instead of duplicating this configuration, it would be better to add a imputation_shared.config file to store this.
What do you think ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.