Conversation
Postrelease 2.3.1
Co-authored-by: Adrien Coulier <adrien.coulier@pixelgen.com>
…op-mpx-support Drop MPX support
…omponent-size Default to 8000 UMIs as minimum component size
Co-authored-by: Adrien Coulier <adrien.coulier@pixelgen.com>
…ma-types Chore/fix json schema types
`file-path` checks the path is not a directory, which doesn't work well with `pipelines_testdata_base_path`.
…iner Add override parameter for experiment summary container
|
Fix review comments regarding 3.0.0 release
FriederikeHanssen
requested changes
Mar 3, 2026
FriederikeHanssen
left a comment
FriederikeHanssen
left a comment
Contributor
There was a problem hiding this comment.
Reminder to update the github keywords once the release is out
Putting a request changes to make sure the detect_technology behavior is intended
Co-Authored-By: Friederike Hanssen <friederike.hanssen@seqera.io>
Fix 2nd round of comments for v3.0.0 release
Contributor
|
AWS test run here: https://cloud.seqera.io/orgs/nf-core/workspaces/AWSmegatests/watch/4dQY1fAINZjh7t/logs please check that it works before releaseing |
Contributor
Author
|
Thanks for your review! The link to the AWS megatests doesn't work though, I land on the "Organizations" page and there is an error message saying the the nf-core organization was not found. I logged in to seqera through my github account, so I was hoping it would import the organization from there, but maybe that's not the case? |
Contributor
|
no that unfortunately doesn't work. we need to add you. Will do this now. |
Contributor
|
done |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3.0.0] - 2026-02-23
Changed
Removed
Enhancements & fixes
Parameters
--experiment_summary_container--save_amplicon_reads--trim_front--trim_tail--max_length--min_length--max_n_bases--avg_qual--dedup--remove_polyg--adapterqc_mismatches--save_qc_passed_reads--save_qc_failed_reads--demux_mismatches--demux_min_length--save_demux_processed_reads--save_demux_failed_reads--markers_ignore--algorithm--max_neighbours--collapse_mismatches--collapse_min_count--save_collapsed_reads--multiplet_recovery--graph_max_refinement_recursion_depth--graph_max_edges_to_split--graph_min_count--save_edgelist--min_size--max_size--dynamic_filter--aggregate_calling--save_raw_component_metrics--save_annotate_dataset--skip_analysis--compute_polarization--compute_colocalization--use_full_bipartite--polarization_transformation--polarization_n_permutations--polarization_min_marker_count--colocalization_transformation--colocalization_neighbourhood_size--colocalization_n_permutations--colocalization_min_region_count--colocalization_min_marker_count--save_analysis_dataset--skip_layout--no_node_marker_counts--layout_algorithm--skip_reportNote
Parameter has been updated if both old and new parameter information is present.
Parameter has been added if just the new parameter information is present.
Parameter has been removed if new parameter information isn't present.