Skip to content

fix: reference test-datasets by commit sha rather than branch name#228

Merged
elhb merged 1 commit into
devfrom
lock-test-dataset-version
Jun 18, 2026
Merged

fix: reference test-datasets by commit sha rather than branch name#228
elhb merged 1 commit into
devfrom
lock-test-dataset-version

Conversation

@elhb

@elhb elhb commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

…name

Summary

Make the test-datasets better "version controlled" by pointing to specific commit rather than branch name.
This way we'll always keep a set connection between pipeline commit and test data commit avoiding backwards compatibility issues.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pixelator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@elhb elhb requested a review from a team as a code owner June 18, 2026 12:07
@elhb elhb requested a review from Aratz June 18, 2026 12:07
@github-actions

github-actions Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 2d0dc1b

+| ✅ 232 tests passed       |+
#| ❔   9 tests were ignored |#
Details

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: tests/default.nf.test
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-pixelator_logo_light.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-06-18 12:08:15

@elhb elhb changed the title fix: point to commit sha on nf-core/test-datasets rather than branch … fix: reference test-datasets by commit sha rather than branch name Jun 18, 2026
@elhb elhb merged commit dcfa53a into dev Jun 18, 2026
21 checks passed
@elhb elhb deleted the lock-test-dataset-version branch June 18, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aratz Aratz Aratz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elhb @Aratz