Fix build with C++20.#114
Open
bavshin-f5 wants to merge 1 commit into
Open
Conversation
OpenTelemetry SDK built with C++20 uses std::span in the API, and we
want to match the standard to avoid type changes at the API boundary.
However, std::span constructor is explicit for non-default Extent,
requiring us to use a more verbose specification instead of an
initializer list.
```
src/trace_context.hpp:75:33: error: converting to ‘opentelemetry::v1::nostd::span<char, 32>’ {aka ‘std::span<char, 32>’} from initializer list would use explicit constructor ‘constexpr std::span<_Type, _Extent>::span(_It, size_type) [with _It = char*; _Type = char; long unsigned int _Extent = 32; size_type = long unsigned int]’
75 | tc.traceId.ToLowerBase16({out, kTraceIdSize});
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry SDK built with C++20 uses std::span in the API, and we want to match the standard to avoid type changes at the API boundary.
However, std::span constructor is explicit for non-default Extent, requiring us to use a more verbose specification instead of an initializer list.