Skip to content

Fix saving etag for incomplete repo.json download. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
qazwsxal wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix saving etag for incomplete repo.json download. #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions knossos/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ def work1(self, part):
data.base = link

if result not in (304, True):
# We got an ETag
with open(dest_path + '.etag', 'w') as hdl:
# We got an ETag, write it to a temp file
with open(dest_path + '.etag.tmp', 'w') as hdl:
hdl.write(result)

break
Expand All @@ -106,6 +106,14 @@ def work1(self, part):
with open(dest_path, 'r') as dest:
data.parse(dest.read())

# We've successfully parsed the downloaded data,
# so we know we've got a complete mods.json.
# It's now safe to replace the existing etag file.
if os.path.isfile(dest_path + '.etag'):
os.unlink(dest_path)

os.rename(dest_path + '.etag.tmp', dest_path + '.etag')

self._public = data

except Exception:
Expand Down