feat(DetailedAccount): addhexstring to token-id definition#49
Open
irfan798 wants to merge 2 commits into
Open
Conversation
- Rename CDDL rule hexstring → hex-string, bytes → bstr across DetailedAccount, HexString, and CoinIdentity (RFC 8610 convention, one name for one concept) - Switch ERC1155/ERC721 example to UAI "contract.tokenId" dot form per NBCR-2024-001, drop the "must be decimal" claim (EIP-1155 token ids are uint256 — rendering is an implementation choice) - Drop ERC20-only framing on HexString promotion (any canonically- hex id is promoted, regardless of chain) - Replace "Shall we really add 0x?" query-comment with a one-line JSDoc explaining the round-trip-parity rule - Collapse HexString's hexadecimal-tag + hex-bytes into a single hex-string = #6.263(bstr) rule - Align CoinIdentity's hex_string → hex-string in CDDL block and JSDoc No wire-format change — tag 263 bytes are byte-for-byte identical, all existing tests pass. Refs LIQ-842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.