Skip to content

mres projects pages#307

Open
amaiaita wants to merge 3 commits intomainfrom
aib-add-masters-projects
Open

mres projects pages#307
amaiaita wants to merge 3 commits intomainfrom
aib-add-masters-projects

Conversation

@amaiaita
Copy link
Copy Markdown
Collaborator

@amaiaita amaiaita commented Mar 25, 2026

Description

What: adding mres project pages to the website

🧠Why?: submitted by students

👨‍💻How?: using python code.

Checklist:

Have checked for the following:

  • The website still builds correctly, and you can view it using mkdocs serve.
  • There are no new "warnings" from mkdocs (see here for existing warnings you can safely ignore)
  • Does your page follow the page template (or here in Markdown)? (need to make a new one specific to NHSE Data Science)
  • Spelling errors
  • Consistent capitalization
  • Consistent numbers
  • Material features incorrectly implemented: search for code blocks and markers (e.g. !!!).
  • Code snippets don't work
  • Images not working
  • Links not working

Where it was tested

  • Github Codespaces - 2-core, 4GB RAM, 32GB hard drive
  • devcontainer.json describes further settings

Existing Warnings

The following are errors that are already existing in the mkdocs build and that you can safely ignore when creating a PR:

INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
             - what_is_data_science/index.md
             - what_is_data_science/Benefits of Data Science in the NHS.md
             - what_is_data_science/How you can learn Data Science.md

Copy link
Copy Markdown

@sculkin-nhs sculkin-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amaia, I have reviewed and requested a few changes, as comments. Hope they make sense.

@AdamHollings
Copy link
Copy Markdown
Contributor

I have tested loading the pages in a github workspace. Was able to serve the website with no issues. Checked that the index for Mres pages looks correct and has all of the new pages present. checked the links work from the side bar and from the MREs index.

checked each page loads and looks correct, no formatting issues.

seems fine apart from Sarah's suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants