Open
Conversation
sculkin-nhs
reviewed
Mar 26, 2026
sculkin-nhs
reviewed
Mar 26, 2026
sculkin-nhs
reviewed
Mar 26, 2026
sculkin-nhs
reviewed
Mar 26, 2026
sculkin-nhs
reviewed
Mar 26, 2026
sculkin-nhs
requested changes
Mar 26, 2026
sculkin-nhs
left a comment
There was a problem hiding this comment.
Hi Amaia, I have reviewed and requested a few changes, as comments. Hope they make sense.
Contributor
|
I have tested loading the pages in a github workspace. Was able to serve the website with no issues. Checked that the index for Mres pages looks correct and has all of the new pages present. checked the links work from the side bar and from the MREs index. checked each page loads and looks correct, no formatting issues. seems fine apart from Sarah's suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
❓What: adding mres project pages to the website
🧠Why?: submitted by students
👨💻How?: using python code.
Checklist:
Have checked for the following:
mkdocs serve.Where it was tested
Existing Warnings
The following are errors that are already existing in the mkdocs build and that you can safely ignore when creating a PR: