Skip to content

Added timeout when disconnecting connector in Windows #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikhalim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added timeout when disconnecting connector in Windows #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/windows/RdmaConnectedSession.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ void RdmaConnectedSession::Destroy()
try {
if (connector.get()) {
OverlappedWrapper overlapped;
HandleHROverlapped(connector->Disconnect(overlapped), connector, overlapped);
// For some reason, EventHandler in Windows waits until RDMA Close is called from Linux's connector session
// before it exits. Adding a timeout to allow the thread to exit earlier.
HandleHROverlappedWithTimeout(connector->Disconnect(overlapped), connector, overlapped, 100);
}
} catch (std::exception&) {
}
Expand Down