Add ptests to verify installation of required NIAUTH packages#1041
Add ptests to verify installation of required NIAUTH packages#1041SandeepR-NI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Yocto ptest package (niauth-tests) intended to verify that ni-auth and niacctbase-sudo are absent from NILRT images, and wires it into the existing smoke ptest packagegroup so it runs in CI. The PR also changes image/package contents by removing ni-auth from the proprietary package list and removing the niacctbase-sudo subpackage from niacctbase.
Changes:
- Introduce
niauth-tests-ptest(recipe + runner + test script) that checksopkgforni-authandniacctbase-sudo. - Add
niauth-tests-ptesttopackagegroup-ni-ptest-smokeso it runs automatically. - Remove
niacctbase-sudopackaging (sudoers integration) fromniacctbaseand removeni-authfrom the proprietary common image package set.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-ni/niauth-tests/niauth-tests.bb | New ptest recipe packaging the niauth absence checks. |
| recipes-ni/niauth-tests/files/test_niauth_packages.sh | Implements the two subtests using opkg list-installed. |
| recipes-ni/niauth-tests/files/run-ptest | ptest entrypoint invoking the test script. |
| recipes-ni/niauth-tests/files/ptest-format.sh | Adds a local ptest output helper script used by the test. |
| recipes-ni/niacctbase/niacctbase.bb | Removes the niacctbase-sudo subpackage and sudoers installation. |
| recipes-core/packagegroups/packagegroup-ni-ptest-smoke.bb | Ensures niauth-tests-ptest runs in smoke ptest jobs. |
| recipes-core/images/includes/nilrt-proprietary.inc | Removes ni-auth from the proprietary common package set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SandeepR-NI
force-pushed
the
niauth-test
branch
2 times, most recently
from
b30d015 to
9fb2b7d
Compare
rajendra-desai-ni
left a comment
rajendra-desai-ni
left a comment
There was a problem hiding this comment.
Follow 50-72 rule for the commit messages
|
@SandeepR-NI I think you should drop the commit to remove ni-auth from proprietary packages and sudoers file from this PR. As the WI linked mentions to just create the test. And the work to remove will be done as part of this WI |
|
@shubhanshumt26 Pls review again and approve. |
@SandeepR-NI Please test with the updated changes and update the testing section. |
- Add niauth-tests ptest recipe with 4 subtests: - pam-plugin-niauth is not installed - ni-auth-networkcontroller is not installed - libnss-niauth is not installed - niacctbase-sudo is not installed Signed-off-by: Sandeep R Kumar <Sandeep.R.Kumar@Emerson.com>
|
@shubhanshumt26 I have tested the updated changes and updated the testing section with the results. |
rajendra-desai-ni
left a comment
rajendra-desai-ni
left a comment
There was a problem hiding this comment.
Update PR title with respect to the changes made.
| @@ -0,0 +1,56 @@ | |||
| #!/bin/bash | |||
| # Verifies that niauth-related packages and niacctbase-sudo are not installed. | |||
There was a problem hiding this comment.
Shouldn't we also have a "test" here to verify ni-auth not included in the BSI? I know it would fail until ni-auth is actually removed, but in which WI would we be including the test if not under this WI?
FYI, @shubhanshumt26
There was a problem hiding this comment.
Yes, we can include that. It will fail until the dependency of ni-auth is removed from ni-auth-webservice. IIRC it will be done in C4 as per discussion with Rich, right @erickshepherdNI ?
I will be in favour of including the test and let it fail few months as the planning of ni-auth depreciation is already done. Thoughts @chaitu236
SandeepR-NI
changed the title
SandeepR-NI
changed the title
Justification
AB#3650248
Changes
recipes-ni/niauth-tests/niauth-tests.bbptest recipetest_niauth_packages.shwith 4 subtestsptest-format.shshared ptest utilitiesrun-ptestentry pointTesting
Manual Testing:
ni-auth-networkcontroller not installed - PASS
libnss-niauth not installed - PASS
niacctbase-sudo not installed - PASS
Suggested Reviewers:
@rajendra-desai-ni
@ni/rtos