ci: make the Expo dependency check advisory, not a hard gate - #94
Merged
Conversation
`npx expo install --check` exits non-zero whenever Expo ships a patch release within SDK 57, which happens every few days. Gating the Quality checks job on it means every unrelated PR goes red until someone runs `expo install --fix` — pure whack-a-mole (see the repeated dep-bump commits). Keep the check running for visibility, but never fail the job on it: on drift it now emits a GitHub warning annotation instead of exiting 1. Real problems (lint, typecheck, tests) still gate as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
npx expo install --checkin the Quality checks job exits non-zero whenever Expo ships a patch release within SDK 57 — which happens every few days. Because the job gates on it, every unrelated PR goes red until someone manually runsexpo install --fixand merges a bump. That's already happened twice in a week (the repeated "bump Expo SDK 57 patch deps" commits), and it red-lit an otherwise-clean native fix.What changed
The check still runs (so drift stays visible), but it no longer fails the job: on drift it emits a GitHub
::warning::annotation instead of exiting 1.The gates that catch real breakage — lint, typecheck, tests — are untouched and still block. This only stops upstream patch drift from red-lighting unrelated PRs.
YAML validated.