Skip to content

Harden OAuth client and token validation#59

Open
haradahinata wants to merge 1 commit into
nick-transition:mainfrom
haradahinata:codex/oauth-security-hardening
Open

Harden OAuth client and token validation#59
haradahinata wants to merge 1 commit into
nick-transition:mainfrom
haradahinata:codex/oauth-security-hardening

Conversation

@haradahinata
Copy link
Copy Markdown

Summary

Fixes three related OAuth security issues:

Notes

The redirect URI helper accepts the current expected redirectUris array and also supports a legacy single redirectUri string if any existing client documents use that shape.

For existing OAuth tokens without expiresAt, validation falls back to createdAt + 90 days; tokens without either timestamp are rejected.

Validation

  • npm ci in functions/
  • npm run build in functions/
  • git diff --check

I saw the earlier discussion about treating these as S-size security fixes under BOUNTIES.md. If you are open to formalizing the three related fixes together, I would be happy to coordinate the payout process you prefer after review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Client secret comparison not timing-safe Security: Access tokens never expire Security: OAuth redirect_uri not validated

1 participant