Repository navigation
Stop notes part-way, and wait for Ollama after a reboot, and v0.33.0 - #52
Merged
Merged
Conversation
Nothing could stop a slow summary: each part was one blocking request of up to ten minutes. The summary request is now streamed over a plain socket read in short slices, so Stop hangs up at once, and Ollama abandons a load or a generation when its client goes (measured with examples/stop_check.rs: 1 ms mid-part, and "aborting load" mid-load with nothing left in memory). The re-pass checks between chunks; the queue and the memory wait check too. A stopped job is its own outcome, not a failure. Notes wait up to a minute for an Ollama installed but not yet answering, instead of failing on the two-second probe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlog resource-safety #10. Nothing could stop a slow summary or re-pass, and an Ollama still starting after a reboot failed the notes outright.
Outcome::Stopped— not a failure, no toast.synthesis/stream.rs) read in 200 ms slices, so it can hang up at any moment; ureq could not be interrupted while Ollama loads. Shutting a cloned socket does not wake a blocked read on Windows (tried), hence the slices.examples/stop_check.rson a 721-segment session: 1 ms to stop mid-part with Ollama loggingcancel task; stopped mid-load, Ollama logs "aborting load" and nothing stays loaded. Full uninterrupted run still writes cited notes.note-stopping,note-stopped;note-regeneratinggains the button.Not verified live: the Ollama wait (needs Ollama quit and restarted); Stop clicked in the real app (wiring covered by unit tests and the fake backend).
/verifygreen; hang-up test mutation-checked.🤖 Generated with Claude Code