Skip to content

refactor(firmware): colocate unit tests with implementations - #55

Merged
nicksan222 merged 1 commit into
feat/firmware-linux-gpio-e2efrom
refactor/firmware-colocate-unit-tests
Sep 25, 2026
Merged

nicksan222 merged 1 commit into
feat/firmware-linux-gpio-e2efrom
refactor/firmware-colocate-unit-tests

Conversation

@nicksan222

Copy link
Copy Markdown
Owner

Stack

Depends on #54. Review this PR against feat/firmware-linux-gpio-e2e (not main); only the test-location changes are included here.

Summary

  • Colocate the pins, button subscription, event channel, hardware event, product-menu, SSID/passphrase, and harness unit tests with their implementations under apps/firmware/src/.
  • Keep only cross-component E2E/Linux and display integration tests under apps/firmware/tests/.
  • Preserve the test assertions and production behavior; update the firmware README to describe the distinction.

Verification

  • just --justfile apps/firmware/justfile check (includes the Linux VM E2E suite)
  • just --justfile apps/firmware/justfile yocto-check
  • just --justfile apps/firmware/justfile cross-build

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T17:26:03.647229Z a9d95f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor

cursor Bot commented Sep 24, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_f1ce4193-47a0-40f1-9012-38c545478fb6)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment; not approved. Cursor Bugbot was present but skipped (usage limit), so its review is incomplete and human review is needed. No reviewers were assigned because the only code owner is the PR author.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@nicksan222
nicksan222 added this pull request to stack #56 September 24, 2026 17:52
@nicksan222
nicksan222 merged commit 86bf095 into main Sep 25, 2026
20 checks passed
@nicksan222
nicksan222 deleted the refactor/firmware-colocate-unit-tests branch September 25, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant