Repository navigation
Fix the macOS and Windows release builds, and drop Intel Macs - #13
Merged
Merged
Conversation
The first release run failed on every platform but Linux, whose fix landed separately.
- macOS: cargo-packager cannot make an icns from a 16-bit PNG ("unsupported ColorType: Rgba16"). The icon is now 8-bit RGBA.
- Windows: tokenizers' default esaxx_fast feature compiles C++ against the static CRT, so linking failed with LNK2005/LNK1169 against the dynamic CRT the rest of the build uses. study-ai drops tokenizers' default features and keeps onig; esaxx only speeds up training a tokenizer, which Study never does.
- Intel macOS: ort 2.0.0-rc.12 ships no ONNX Runtime build for x86_64-apple-darwin, so the platform is gone from the matrix, the update feed and the README.
The Linux AppImage is now built on Ubuntu 24.04, so the README's glibc floor drops to 2.39.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e679ab422
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.0 release run failed on every platform. Linux was fixed in #12; this fixes the rest.
ERROR unsupported ColorType: Rgba16. cargo-packager can't make an icns from the 16-bitpackaging/icon.png, so it's re-encoded as 8-bit RGBA (same image).LNK2005×83, thenLNK1169, linkingstudy-ai. tokenizers' defaultesaxx_fastfeature buildsesaxx-rsC++ withstatic_crt(true)(libcpmt), which collides with the dynamic CRT (msvcprt) used everywhere else.study-ainow takes tokenizers withdefault-features = false, features = ["onig"]. esaxx only speeds up Unigram training; Study only loads tokenizers.ort does not provide prebuilt binaries for the target x86_64-apple-darwin. Dropped from the release matrix,release.sh's platform list (so the update feed no longer requires it) and the README.cargo test -p study-ai --libpasses locally. After merge I'll re-pointv0.1.0at main to rerun the release (no release was published from the failed run).