Repository navigation
Publish the website from apps/landing, with captures made by the showcase - #15
Merged
Merged
Conversation
The installer configuration, plists, icon and release script belong to the desktop app, beside its code. release.sh still runs from the repository root, where Cargo and dist/ live.
The highlighter tile with the open book replaces the "S" placeholder in the welcome tour and leads both title bars. The masters live in assets/logo; the app rasterises them in colour at the device pixels they cover, the simplified mark under 40 design pixels. A test keeps the installers' icon equal to the full mark and writes the new one when the mark changes.
Waiting jobs matched no filter but All. A test now checks that every job status falls in exactly one group.
`just docs-media` plays scripted scenes on the showcase's private desktop in each language and theme: lossless WebP stills taken once the screen settles, and short MP4 clips with a poster. The desktop now takes a screen size and scale (the GIF's 1080p, the docs' 1440x900 at 2x), the tour can drag, and readiness checks look for contrast so they work in light and dark. `missing` makes only the scenes with a file missing, so a fresh checkout captures everything and a warm one nothing. The demo GIF moves to the website's public folder.
An Astro site on Bun, published to GitHub Pages under /study: the landing page and one docs page per feature, in English and Italian. Nothing on it is drawn by hand. Its captures of the app are the showcase's scenes, made on every deploy and never committed; the favicon, home-screen icon and link previews are drawn at build time from the logo masters, the app's fonts and a capture of a session; the fonts and icons are study-ui's own files. A published build shows only the exact capture for a page's language and theme, so one that failed to be made fails the deploy. A test in study-showcase checks that every capture the site names is a scene of the right kind, and that every scene is shown. `just check` and CI type-check the site with `astro check`. The README's demo GIF moves to the site, so the Demo workflow and the committed GIF go.
The lead starts it in the shared optional slot when a delivered change or a release alters what the website says or shows. It changes the site and the docs' scenes, never a capture by hand, keeps English and Italian equal and invents no claims.
Without script the passage's highlights are plain words and the four pieces show one after another, so they no longer claim to be buttons and tab panels that do nothing. The scripts that make them work now give them those roles.
The sidebar's sections are declared once, beside the schema that checks them, and the build fails when a docs page exists in only one language, naming the file to add.
The three image sizes hints were numbers worked out by hand from each crop and the panel's columns, so a new crop meant redoing them. Learn now derives them from the crop boxes and the panel's width, giving the same values.
Three landing sections defined or inlined their own copy of anchor.ts's relayout. They now import it; only Download's inline script, which cannot import, still dispatches the event.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Website: https://nicksan222.github.io/study/ (Italian: https://nicksan222.github.io/study/it/)
Publishes Study's website from
apps/landing(Astro on Bun, GitHub Pages under/study/), with every capture of the app made by the showcase rather than by hand.study-showcasenow makes the docs' stills and clips as well as the demo GIF, on its private desktop from the seeded sample. None is committed: the new Landing workflow makes them all on every push to main, andjust landingmakes any that are missing. A test fails if the site names a capture that is not a scene, or a scene is never shown; a production build fails if a capture is missing for any language or theme.study-ui/assets, so nothing is copied.just checkand CI now type-check the website (just landing-check, a new parallelsitejob thatTest and buildwaits for). Docs pages must exist in both languages.apps/desktop; the old Demo workflow and the committedassets/demo.gifgo, and the README shows the GIF from the site. A "site" role joins the agent team, limited to scenes for captures.Note: the website's house icon is now the app's filled glyph. The README's demo GIF resolves once the first Landing deploy runs.
Checklist
just checkpasses.study-localization, in English and Italian.just landingserves them locally.)