Repository navigation
Deploy the website from committed captures - #16
Merged
Merged
Conversation
Every Landing deploy built the app and recorded every scene on software rendering, which took many minutes and failed when wf-recorder was slow to finish on the runner. The captures are now committed, and the deploy only builds the site with Bun. The new Captures workflow, run by hand, makes them all again (`just captures`) and opens a pull request with what changed, starting CI on it. A test checks that the committed captures are exactly the scenes' files, and wf-recorder gets a minute to finish on a slow machine.
nicksan222
enabled auto-merge (squash)
October 4, 2026 19:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb1d9fa610
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The first Landing deploy failed: it built the app and recorded every scene on the runner's software rendering, and
wf-recordertook more than 10 s to finish a clip. Making captures on every deploy was also slow (15+ minutes) for a site that builds in seconds.justand Bun and runsjust landing-build.just capturesmakes them all again, then it opens or updates a pull request from thecapturesbranch to look over and merge, and starts CI on it (a pull request opened by a workflow starts none itself).just capturesclears the old files first, and a new test checks the committed captures are exactly every scene's files, none missing and none left over.wf-recordergets a minute to finish on a slow machine.AGENTS.md,CONTRIBUTING.md, the CI skill, the site role and the showcase docs say so.Website: https://nicksan222.github.io/study/
Checklist
study-showcasetests, Clippy and shellcheck pass; the site builds.