Use MiniMessage in favor of legacy color codes - #143
Open
Earth1283 wants to merge 1 commit into
Open
Conversation
Member
|
Hi, @Earth1283! Thank you once again for your contribution! I’ll take a closer look at the PR in the next few days. My concern is how Adventure support will work for older versions, such as Paper 1.8.9, which don’t implement the API in the Player interface. One idea I had is that, instead of sending the Adventure component to the player in unsupported versions, maybe we should convert them to the legacy color codes first? |
Open
Author
|
ViaRewind (the plugin that allows 1.7.x & 1.8x clients to join 1.9+ servers) hooks into ViaVersion, which already handles MiniMessage Deserialization for us, and automatically downsamples the RGB codes to the legacy color codes (§0 through §f), so they won't crash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the legacy color codes (§ and &) to newer MiniMessage colors (such as gradient:#HEXHEX:HEXHEX).