Skip to content

fixed chapter 09 formatting issue - #1

Open
yzyouzhang wants to merge 1 commit into
niconielsen32:mainfrom
yzyouzhang:main
Open

yzyouzhang wants to merge 1 commit into
niconielsen32:mainfrom
yzyouzhang:main

Conversation

@yzyouzhang

@yzyouzhang yzyouzhang commented Jun 15, 2025

Copy link
Copy Markdown

Important

Reformatted 09_generative_models/generative_models.py for improved readability without altering functionality.

  • Formatting:
    • Reformatted 09_generative_models/generative_models.py for improved readability.
    • Added line breaks and indentation to separate sections and functions clearly.
    • No changes to logic or functionality of the code.

This description was created by Ellipsis for 335a7e5. You can customize this summary. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 335a7e5 in 1 minute and 18 seconds. Click for details.
  • Reviewed 483 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. 09_generative_models/generative_models.py:1
  • Draft comment:
    Header and multi-line docstring are now properly formatted. Good job!
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. 09_generative_models/generative_models.py:334
  • Draft comment:
    Improved spacing and inline comments in the GAN training block enhance readability.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. 09_generative_models/generative_models.py:460
  • Draft comment:
    File does not end with a newline. Please add a newline at the end for POSIX compliance.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_WvvpEZ75P2xmLTnZ

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant