Skip to content

[BugFix] Fix showing different expand view height #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirrudd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BugFix] Fix showing different expand view height #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions app/src/main/java/com/nikhilpanju/fabfilter/main/MainListAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ class MainListAdapter(context: Context) : RecyclerView.Adapter<MainListAdapter.L
private val listItemVerticalPadding: Float by bindDimen(context, R.dimen.list_item_vertical_padding)
private val originalWidth = context.screenWidth - 48.dp
private val expandedWidth = context.screenWidth - 24.dp
private var originalHeight = -1 // will be calculated dynamically
private var expandedHeight = -1 // will be calculated dynamically

// filteredItems is a static field to simulate filtering of random items
private val filteredItems = intArrayOf(2, 5, 6, 8, 12)
Expand Down Expand Up @@ -115,38 +113,33 @@ class MainListAdapter(context: Context) : RecyclerView.Adapter<MainListAdapter.L
} else {

// show expandView only if we have expandedHeight (onViewAttached)
holder.expandView.isVisible = expand && expandedHeight >= 0
holder.expandView.isVisible = expand && holder.expandedHeight >= 0
setExpandProgress(holder, if (expand) 1f else 0f)
}
}

override fun onViewAttachedToWindow(holder: ListViewHolder) {
super.onViewAttachedToWindow(holder)

// get originalHeight & expandedHeight if not gotten before
if (expandedHeight < 0) {
expandedHeight = 0 // so that this block is only called once

//store the original and expanded height with in their respected holder
holder.cardContainer.doOnLayout { view ->
originalHeight = view.height
holder.originalHeight = view.height

// show expandView and record expandedHeight in next layout pass
// (doOnPreDraw) and hide it immediately. We use onPreDraw because
// it's called after layout is done. doOnNextLayout is called during
// layout phase which causes issues with hiding expandView.
holder.expandView.isVisible = true
view.doOnPreDraw {
expandedHeight = view.height
holder.expandedHeight = view.height
holder.expandView.isVisible = false
}
}
}
}

private fun setExpandProgress(holder: ListViewHolder, progress: Float) {
if (expandedHeight > 0 && originalHeight > 0) {
if (holder.expandedHeight > 0 && holder.originalHeight > 0) {
holder.cardContainer.layoutParams.height =
(originalHeight + (expandedHeight - originalHeight) * progress).toInt()
(holder.originalHeight + (holder.expandedHeight - holder.originalHeight) * progress).toInt()
}
holder.cardContainer.layoutParams.width =
(originalWidth + (expandedWidth - originalWidth) * progress).toInt()
Expand Down Expand Up @@ -194,7 +187,7 @@ class MainListAdapter(context: Context) : RecyclerView.Adapter<MainListAdapter.L
val itemExpanded = position >= 0 && adapterList[position] == expandedModel
holder.cardContainer.layoutParams.apply {
width = ((if (itemExpanded) expandedWidth else originalWidth) * (1 - 0.1f * progress)).toInt()
height = ((if (itemExpanded) expandedHeight else originalHeight) * (1 - 0.1f * progress)).toInt()
height = ((if (itemExpanded) holder.expandedHeight else holder.originalHeight) * (1 - 0.1f * progress)).toInt()
// log("width=$width, height=$height [${"%.2f".format(progress)}]")
}
holder.cardContainer.requestLayout()
Expand Down Expand Up @@ -222,6 +215,9 @@ class MainListAdapter(context: Context) : RecyclerView.Adapter<MainListAdapter.L
///////////////////////////////////////////////////////////////////////////

class ListViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
var originalHeight = -1 // will be calculated dynamically
var expandedHeight = -1 // will be calculated dynamically

val expandView: View by bindView(R.id.expand_view)
val chevron: View by bindView(R.id.chevron)
val cardContainer: View by bindView(R.id.card_container)
Expand Down