Repository navigation
fix: improve pruning behavior for non-showing subtrees - #5
Merged
Merged
Conversation
To reduce the number of ATSPI calls that are needed, peck pruned subtrees whose root had SHOWING=false. As it turns out, this approach was unreliable, and resulted in on-screen elements getting dropped. From my testing, this seemed to affect deeply nested elements in web documents (e.g. GitHub's issue list in Firefox). The system now keeps track of whether the given subtree is within a DocumentWeb/DocumentFrame node, and for these subtrees avoids pruning non-SHOWING elements. Supporting changes: - Add `dump-tree --all` flag to print every on-screen element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the number of ATSPI calls that are needed, peck pruned subtrees whose root had SHOWING=false. As it turns out, this approach was unreliable, and resulted in on-screen elements getting dropped. From my testing, this seemed to affect deeply nested elements in web documents (e.g. GitHub's issue list in Firefox).
The system now keeps track of whether the given subtree is within a DocumentWeb/DocumentFrame node, and for these subtrees avoids pruning non-SHOWING elements.
Supporting changes:
dump-tree --allflag to print every on-screen element