[Bugfix] Win_path is enforced as directory path, not file path#213
Merged
nikopueringer merged 2 commits intonikopueringer:mainfrom Apr 7, 2026
Merged
[Bugfix] Win_path is enforced as directory path, not file path#213nikopueringer merged 2 commits intonikopueringer:mainfrom
nikopueringer merged 2 commits intonikopueringer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This change aims to reduce the confusion when user drags and drop a footage/file instead of a directory as instructed. This brings upsetting clients to discord server and ask why this program breaks.
https://discord.com/channels/1128442184715214980/1476324228834791474/1477023833729794222
This pull request changes how interactive wizard process the win_path parameter. Since we are making the assumption that this input is a directory in the logic down below, we'll fetch the parent directory from the dropped file.
How was it tested?
Dragging a footage will open the interactive wizard into the parent directory instead.
Also ran
uv run pytest && uv run ruff check && uv run ruff format --checkand all passed.Checklist
uv run pytestpassesuv run ruff checkpassesuv run ruff format --checkpasses