Repository navigation
0.28.0: version, changelog, Action pins; the PR comment checks toolmenu mcp - #77
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kCPJXf7SykHNoEUW3LYNt
toolmenuVerdict: ✓ unchanged: the same menu and the same findings. Nothing to accept. Findings against the baseline: 0 new, 0 gone, 0 changed. toolmenu diff:
|
| Rule | Finding | |
|---|---|---|
| info | write/no-dry-run · unsure |
2 tools are annotated as destructive, and toolmenu found no dry_run/preview-style parameter and no preview tool for the same thing. Where a mistake is costly to undo, a dry run lets the agent see what would change while it can still back out. · snapshot_menu, check_session → Next: Where the effect is hard to undo, add a dry_run parameter that returns what would change without changing it. If it's cheap to undo, or a preview exists under another name, ignore this. |
0 errors, 0 warnings, 1 info
Where the tokens go (estimate): the top 5 tools are 93% of the menu
| Share | Tool | Tokens | Description | Schema |
|---|---|---|---|---|
| 30% | snapshot_menu |
~461 | ~99 | ~353 |
| 26% | check_session |
~394 | ~102 | ~283 |
| 15% | review_baseline |
~231 | ~65 | ~156 |
| 12% | diff_menus |
~187 | ~39 | ~138 |
| 10% | check_auth |
~149 | ~86 | ~54 |
- repeated: cwd (~37 tokens) in 4 tools, ~148 in all
A tool's schema can't $ref another tool's, so a block shared across tools is paid once per tool: only a smaller block saves tokens there.
toolmenu · token counts are estimates
The Action's PR comment came from its dogfood run on test/fixtures/sdk-server.mjs, three tools, so every PR here reported "3 tools" and never toolmenu's own server. The Action keeps one comment per PR, so the fixture run (still testing the Action) now posts none, and a second run on `node dist/cli.js mcp` against the new docs/toolmenu-menu.json posts it: 6 tools, the dry-run hint, and a diff for any PR that changes a tool's name, description or schema. test/mcp.test.mjs fails when docs/toolmenu-menu.json or the badge no longer match the server; AGENTS.md's command writes both. A version bump alone is no difference (diff reports nothing). Tests: npm test, 725 passing. action/run.sh on toolmenu mcp with that baseline: verdict unchanged, 6 → 6 tools. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kCPJXf7SykHNoEUW3LYNt
CHANGELOG 0.28.0 gains the weekly bench's --read-resources and the build-vendors.py kind fix, and loses a broken line. The three examples in docs/github-action.md that still pinned v0.16.1 pin v0.28.0. The lists/resource-unread row says what the code says: something the run lacks, not the machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
package.json,package-lock.jsonandserver.json(version, and the package'sversion).CHANGELOG.md: Unreleased becomes 0.28.0, with the weekly bench's--read-resourcesand thebuild-vendors.pykind fix under Repository.niksa90/toolmenu@v0.28.0inREADME.md,docs/github-action.mdanddocs/ci.md. That includes the threedocs/github-action.mdexamples still onv0.16.1.actionjob runs the Action twice.test/fixtures/sdk-server.mjs(three tools) withcomment: 'false', still testing the Action.node dist/cli.js mcpagainst the newdocs/toolmenu-menu.json; this run posts the comment.test/mcp.test.mjsfails whendocs/toolmenu-menu.jsonordocs/toolmenu-badge.jsonno longer match the server. The command inAGENTS.mdwrites both.docs/RULES.md: thelists/resource-unreadrow says "something the run lacks", as the code does.Why
0.28.0:
snapshot --read-resourcesand its three rules are a new flag and new rules, so a minor version. It also carries theapps/resourcefix for reads that failed for the run's reasons.The PR comment: the Action keeps one comment per PR, and the only run here was the fixture's. Every PR reported "3 tools", never toolmenu's own six.
Tests
npm test: 725 passing.node dist/cli.js --versionprints 0.28.0.toolmenu mcprun: 6 → 6 tools, verdict unchanged, the dry-run hint only.serverInfo.versiongive no diff finding, so a release bump doesn't make the comment report a change.