Repository navigation
CHANGELOG 0.28.0: the old pins are fixed, not still there - #78
Merged
Merged
Conversation
toolmenuVerdict: ✓ unchanged: the same menu and the same findings. Nothing to accept. Findings against the baseline: 0 new, 0 gone, 0 changed. toolmenu diff:
|
| Rule | Finding | |
|---|---|---|
| info | write/no-dry-run · unsure |
2 tools are annotated as destructive, and toolmenu found no dry_run/preview-style parameter and no preview tool for the same thing. Where a mistake is costly to undo, a dry run lets the agent see what would change while it can still back out. · snapshot_menu, check_session → Next: Where the effect is hard to undo, add a dry_run parameter that returns what would change without changing it. If it's cheap to undo, or a preview exists under another name, ignore this. |
0 errors, 0 warnings, 1 info
Where the tokens go (estimate): the top 5 tools are 93% of the menu
| Share | Tool | Tokens | Description | Schema |
|---|---|---|---|---|
| 30% | snapshot_menu |
~461 | ~99 | ~353 |
| 26% | check_session |
~394 | ~102 | ~283 |
| 15% | review_baseline |
~231 | ~65 | ~156 |
| 12% | diff_menus |
~187 | ~39 | ~138 |
| 10% | check_auth |
~149 | ~86 | ~54 |
- repeated: cwd (~37 tokens) in 4 tools, ~148 in all
A tool's schema can't $ref another tool's, so a block shared across tools is paid once per tool: only a smaller block saves tokens there.
toolmenu · token counts are estimates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CHANGELOG.md, 0.28.0, Repository: "three examples still pinnedv0.16.1" becomes "Every Action pin in the docs isv0.28.0, including three examples indocs/github-action.mdthat were still onv0.16.1."Why
The release notes are this section. The old line described the problem the release fixed, and read as if it were still there.
Tests
test/protocols.test.mjspasses; the rest of the change is one line of the changelog.