Repository navigation
Retire description/late-instruction - #82
Merged
Merged
Conversation
It flagged instructions past character 280, a cut no client documents: the number came from one private client. The documented cuts (Claude Code 16,384 and 4,096, Amazon Q CLI 10,024) are description/buried's, as is any descriptionLimit a user sets. A config naming the old id is accepted and changes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kCPJZAgTv3Bna4BGLzw2o
toolmenuVerdict: ✓ unchanged: the same menu and the same findings. Nothing to accept. Findings against the baseline: 0 new, 0 gone, 0 changed. toolmenu diff:
|
| Rule | Finding | |
|---|---|---|
| info | write/no-dry-run · unsure |
2 tools are annotated as destructive, and toolmenu found no dry_run/preview-style parameter and no preview tool for the same thing. Where a mistake is costly to undo, a dry run lets the agent see what would change while it can still back out. · snapshot_menu, check_session → Next: Where the effect is hard to undo, add a dry_run parameter that returns what would change without changing it. If it's cheap to undo, or a preview exists under another name, ignore this. |
0 errors, 0 warnings, 1 info
Where the tokens go (estimate): the top 5 tools are 93% of the menu
| Share | Tool | Tokens | Description | Schema |
|---|---|---|---|---|
| 30% | snapshot_menu |
~461 | ~99 | ~353 |
| 26% | check_session |
~394 | ~102 | ~283 |
| 15% | review_baseline |
~231 | ~65 | ~156 |
| 12% | diff_menus |
~187 | ~39 | ~138 |
| 10% | check_auth |
~149 | ~86 | ~54 |
- repeated: cwd (~37 tokens) in 4 tools, ~148 in all
A tool's schema can't $ref another tool's, so a block shared across tools is paid once per tool: only a smaller block saves tokens there.
toolmenu · token counts are estimates
- RETIRED_RULES replaces RULE_ALIASES, which had no entries left. toolmenu explain on a retired id says it was retired and why; a config that names one loads, with a line saying the setting changes nothing. - docs/SPEC.md is frozen: its row stays, with a dated note. - CHANGELOG: Amazon Q's 10,024 is reported, not documented. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kCPJZAgTv3Bna4BGLzw2o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
description/late-instructionrule (src/rules/description.ts,src/rules/index.ts).RETIRED_RULES(insrc/rules/index.ts) replacesRULE_ALIASES, whose one entry was this rule.toolmenu explain description/late-instruction(andexplain_rule) says it was retired and why; a config that names it loads, with a stderr line saying the setting changes nothing.description/buriedis unchanged: it checks Claude Code's cuts, theamazon-qpreset, or thedescriptionLimita user sets (descriptionLimit: 280still works for a client that cuts there).docs/RULES.mdanddocs/snapshot.md;docs/SPEC.mdkeeps its frozen table with a dated note;docs/PROTOCOLS.mdregenerated; CHANGELOG under Unreleased.Why
The rule flagged instructions past character 280, which no client documents. The number came from one private client (FINDINGS, "Buried routing instructions"). On every client toolmenu has a cut for, the finding ended with "so there they arrive". It was the one note on
serbia-prices-mcp0.1.5, and on Firecrawl and Supabase in the golden set.Tests
npm test: 727 passing. The rule's three tests are replaced by one that checks an instruction at character 440 says nothing and thatdescriptionLimit: 280still getsdescription/buried. New:explainon the retired id, in text and JSON, and a config naming it loads with the line on stderr. The golden findings lose their twolate-instructionlines.