Skip to content

Fix brightness dropped when color_temp is set alongside it in turn_on() #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imwithsam wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Fix brightness dropped when color_temp is set alongside it in turn_on() #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions custom_components/cync_lights/cync_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,13 @@ async def turn_on(self, attr_rgb, attr_br, attr_ct) -> None:
self.hub.combo_control(True, round(attr_br*100/255), 255, [255,255,255], controller, self.mesh_id, seq)
elif attr_rgb is not None and attr_br is None:
self.hub.combo_control(True, self.brightness, 254, attr_rgb, controller, self.mesh_id, seq)
elif attr_ct is not None and attr_br is not None:
# combo_control accepts a real 0-100 color-temp percentage in its
# color_tone byte (not just the 254=RGB/255=none mode markers used
# above), so brightness+color_temp can be sent atomically instead of
# as two separate calls (which silently dropped brightness before).
color_temp = round(100*((attr_ct - self.min_color_temp_kelvin) / (self.max_color_temp_kelvin - self.min_color_temp_kelvin)))
self.hub.combo_control(True, round(attr_br*100/255), color_temp, [0,0,0], controller, self.mesh_id, seq)
elif attr_ct is not None:
self.hub.turn_on(controller, self.mesh_id, seq)
# Cync uses the range 0% to 100% to set the color temp, so we need to
Expand Down Expand Up @@ -567,6 +574,9 @@ async def turn_on(self, attr_rgb, attr_br, attr_ct) -> None:
self.hub.combo_control(True, round(attr_br*100/255), 255, [255,255,255], controller, self.mesh_id, seq)
elif attr_rgb is not None and attr_br is None:
self.hub.combo_control(True, self.brightness, 254, attr_rgb, controller, self.mesh_id, seq)
elif attr_ct is not None and attr_br is not None:
color_temp = round(100*((attr_ct - self.min_color_temp_kelvin) /(self.max_color_temp_kelvin - self.min_color_temp_kelvin)))
self.hub.combo_control(True, round(attr_br*100/255), color_temp, [0,0,0], controller, self.mesh_id, seq)
elif attr_ct is not None:
# Cync uses the range 0% to 100% to set the color temp, so we need to
# calculate the percentage of the color temp range that is being requested
Expand Down