feat(parser): Properly support semantic versions#43
Open
hairyhenderson wants to merge 1 commit intonikunjy:masterfrom
Open
feat(parser): Properly support semantic versions#43hairyhenderson wants to merge 1 commit intonikunjy:masterfrom
hairyhenderson wants to merge 1 commit intonikunjy:masterfrom
Conversation
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
nikunjy
approved these changes
Nov 14, 2025
Author
|
@nikunjy I see you've approved this PR - is there anything blocking it from being merged? |
Author
|
@nikunjy any chance you can merge this? It's still causing issues |
thomaspoignant
added a commit
to thomaspoignant/go-feature-flag
that referenced
this pull request
Feb 12, 2026
…dling Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged. Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
4 tasks
kodiakhq Bot
pushed a commit
to thomaspoignant/go-feature-flag
that referenced
this pull request
Feb 12, 2026
…elease handling (#4808) * fix(wasm): add replace for nikunjy/rules to fix semver prerelease handling Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged. Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> * tidy Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> --------- Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42, potentially.
After I realized that the
VERSIONgrammar didn't support anything other thanx.y.zform versions, the issues I've been having with prerelease identifiers make much more sense!I've made a few changes to fix this:
SemverGrammar.g4parser/gen.shto support eitherantlr4orantlrcommands (it's the latter on my system, but can't assume the same elsewhere)github.com/blang/semver/v4Hopefully this all makes sense, and can be merged quickly!