Repository navigation
feat: attach to the machines a host's Herdr saved - #6
Merged
Merged
Conversation
Sync native/ and crates/ with Bellterm for Android at nimrc/bellterm#30. The session sidebar lists the host and the SSH machines its Herdr saved with herdr machine add; tapping one attaches to it through the host's own ssh, and the machine is saved as a node via its host. bellterm-ffi exposes list_machines. MachineTests covers routes, storage and parsing, and renders the sidebar with machines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings nimrc/bellterm#30 to iOS: it fixes nimrc/bellterm#29, where running
herdr --remote Bin a pane on A only showed B as that pane's terminal, so the workspace list stayed A's.What changed
native/andcrates/are copied from nimrc/bellterm main and are identical to Android's again.ssh <bridge policy> -- <target> '<command>'on the host, so the host's keys, ssh config and known hosts sign in to the machine.machines::listreadsherdr machine list --jsonon the host.bellterm-ffiexposeslist_machines(config_json).Node.machineholds the SSH target.Routesleaves the machine out of our SSH hops, sends it asrelay, and asks only for the hops' passwords.NodeStore.machine(host:…)saves a machine as a node via its host. Machines are deleted with their host and never offered as jump hosts.Screenshots
MachineTests.sidebarListsTheHostsMachinesrenders the sidebar in a window on the CI simulator (iPhone Duo). It fails if nothing drew.The full flow (listing the machine, switching to it, its own workspace, and back) runs end to end on an Android emulator in nimrc/bellterm's CI, against the same shared core.
Tests
MachineTests: routes skip the machine hop and its password,Noderound-tripsmachine,Machineparsing, store deletion and jump candidates, and the sidebar render.