Remove NodeType::Unexpected.#12
Open
explodes wants to merge 1 commit into
Open
Conversation
This node type was only created when parsing possibly bad data. By creating an error state before creating the unexpected NodeType, we can remove this type from the code altogether, resulting in fewer branches throughout the rest of the library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enum
NodeType::Unexpectedis only created when parsing possibly bad data.By creating an error state before creating the unexpected NodeType, we can remove this type from the code altogether, resulting in fewer branches throughout the rest of the library.
When encountering the bad data, a new error is returned: Error::InvalidData.
The pub trait:
From<u8> for NodeTypeis removed.The pub trait:
TryFrom<u8> for NodeTypeis added.The pub enum
Error::InvalidDatais added.Fixes #11