Fix failing tests run in parallel#13
Open
explodes wants to merge 1 commit into
Open
Conversation
Running tests in parallel (default behavior) means that multiple tests will work with the /tmp/db file. This results in unpredicable test results. Using self-deleting tempdirs, we can work around this. Note that the WAL is automatically placed in the same directory as the db with a fixed name, so this temp directory actually creates a unique, safe place for the WAL file as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running tests in parallel (default behavior) means that multiple tests will work with the
/tmp/dband/tmp/walfiles simultaneously, resulting in unpredictable tests.Using self-deleting tempdirs, we can work around this.
Note that the WAL is automatically placed in the same directory as the db with a fixed name, so this temp directory actually creates a unique, safe place for the WAL file as well.