Skip to content

ENH: Support flexible CIFTI combinations#3340

Draft
tsalo wants to merge 5 commits into
nipreps:masterfrom
tsalo:flexible-cifti
Draft

ENH: Support flexible CIFTI combinations#3340
tsalo wants to merge 5 commits into
nipreps:masterfrom
tsalo:flexible-cifti

Conversation

@tsalo

@tsalo tsalo commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

Closes #3330. This is ongoing. I am starting with the space parsing (linked with nipreps/niworkflows#883) and will move onto actual processing from there.

Changes proposed in this pull request

  • Parse CIFTI --output-spaces options using the pattern <surface_space>:<surface_entity>:<value>::<volume_space>:<volume_entity>:<value>.

@tsalo tsalo marked this pull request as draft August 6, 2024 13:38
@codecov

codecov Bot commented Aug 6, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.27%. Comparing base (fe7c9ff) to head (ae23fc8).
⚠️ Report is 535 commits behind head on master.

Files with missing lines Patch % Lines
fmriprep/config.py 0.00% 8 Missing ⚠️
fmriprep/workflows/bold/base.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fe7c9ff) and HEAD (ae23fc8). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (fe7c9ff) HEAD (ae23fc8)
7 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3340       +/-   ##
===========================================
- Coverage   71.03%   47.27%   -23.77%     
===========================================
  Files          56       56               
  Lines        4233     4239        +6     
  Branches      638      580       -58     
===========================================
- Hits         3007     2004     -1003     
- Misses       1114     2163     +1049     
+ Partials      112       72       -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add other CIFTI spaces

1 participant