Skip to content

Update shared-component-logic.js #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaysonLovesJesus wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update shared-component-logic.js #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
983a19f
Update shared-component-logic.js
JaysonLovesJesus Jan 21, 2026
9cf9bca
Update shared-component-logic.js
JaysonLovesJesus Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions spotlight/shared/shared-component-logic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ export class SharedSpotlightLogic {
static combineResults(instantSuggestion, asyncSuggestions) {
const combined = [];

// Add instant suggestion first (if exists)
if (instantSuggestion) {
combined.push(instantSuggestion);
}

// Add async suggestions, filtering out duplicates of the instant suggestion
for (const asyncResult of asyncSuggestions) {
const isDuplicate = instantSuggestion && SpotlightUtils.areResultsDuplicate(instantSuggestion, asyncResult);
Expand All @@ -38,6 +33,12 @@ export class SharedSpotlightLogic {
}
}

// Add instant suggestion second (or first if contains space) (if exists)
if (instantSuggestion) {
const first = instantSuggestion.metadata?.query?.match(/[^A-z]/);
combined.splice(first ? 0 : 1, 0, instantSuggestion);
}

return combined;
}

Expand Down Expand Up @@ -181,4 +182,4 @@ export class SharedSpotlightLogic {
}
};
}
}
}