Repository navigation
ci: report all workspace tests in hosted CI - #202
Conversation
ce73091 to
3fc1162
Compare
nishuzumi
left a comment
There was a problem hiding this comment.
Reviewed 3fc1162 plus my one-line follow-up. pnpm -r --no-bail test in the Linux job is the right fix for the first-fail bail: the hosted run on this head reported all 21 workspaces (3 failing, 18 passing) instead of stopping at Aave, and the job still exits non-zero. Local pnpm test is unchanged; the CONTRIBUTING note tells contributors how to read a red job whose failing package is not in their diff.
The no-bail run immediately paid for itself: it surfaced that the Merkl live suite fails on the hosted runner with Merkl rewards request failed: fetch failed. That is the egress allowlist, not the adapter — harden-runner blocks api.merkl.xyz, which #187 needed and which the bail had hidden. I pushed api.merkl.xyz:443 into allowed-endpoints on this branch since it is the same file and the same "make hosted CI report the truth" concern.
This closes the bail half of #195. The tripwire half — expiry checks living in a scheduled live-verify run rather than in every PR's gate — is still open there.
Summary
Addresses #195.
Hosted CI stopped at the first failing workspace package, which could hide results from later packages when an unrelated live test failed.
This patch:
pnpm -r --no-bail testpnpm testbehavior unchanged#200 already removed the expired Aave quarantine that originally exposed #195. This patch does not change Aave, Kuru, package code, or the live verification workflow.
Verification
Local:
pnpm build: passedpnpm typecheck: passedpnpm lint: passedenv MOSS_SKIP_E2E=1 pnpm -r --no-bail test: passed with all workspaces reportinggit diff --check: passedHosted CI:
windows-offlinepassedThe live failures are outside this patch. Aave is tracked in #201 and Kuru in #194. The no-bail run also surfaced a Merkl request failure that was previously hidden behind the earlier failure.
No package or lockfile changes.