fix(core): ReslideServerEmbed の use client 境界を正しく分離 - #80
Merged
Conversation
tsdown が ReslideEmbedClient を server.mjs にインライン化し "use client" ディレクティブが消失していた。ReslideEmbedClient を独立 entry にし、 banner で "use client" を付与することで、Next.js bundler が正しく Server/Client 境界を認識するようにした。 - ReslideEmbedClient.tsx を tsdown entry に追加 - banner 関数で ReslideEmbedClient.mjs と embed.mjs に "use client" 付与 - ビルド出力の RSC 境界を検証するテスト追加 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ビルド出力テストで node:fs を使用するため明示的に追加。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReslideEmbedClientをserver.mjsにインライン化し、"use client"ディレクティブが消失していたバグを修正ReslideEmbedClient.tsxを独立した tsdown entry に追加し、bannerで"use client"を付与embed.mjsにも"use client"banner を付与(軽量 Client Component エントリポイント)ビルド出力の変更
Before:
After:
Test plan
vp check— lint, format, 型チェック通過vp test— 全99件パス(新規5件含む)ReslideServerEmbedが createContext エラーなく動作することを確認🤖 Generated with Claude Code