fix(core): ReslideEmbed が高さ固定の親なしで高さ0になるバグを修正 - #82
Merged
Conversation
aspectRatio 指定時に最外コンテナで height:100% → aspect-ratio に変更。 Deck の letterbox-inner からも height:100% を削除し aspect-ratio との 競合を解消。フローレイアウトへの埋め込みが正しく動作するようになった。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReslideEmbedの最外コンテナがheight: 100%を使用していたため、高さ固定の親がないフローレイアウト（ブログ記事等）に埋め込むと高さが0に崩壊していたバグを修正aspectRatio指定時はheight: 100%ではなくaspect-ratioを最外コンテナに設定Deckの.reslide-letterbox-innerからheight: 100%を削除しmaxHeight: 100%に変更（aspect-ratioとの競合を解消）aspectRatio: 0（親に合わせるモード）では従来通りheight: 100%を使用Before / After
Test plan
vp check— lint, format, 型チェック通過vp test— 全105件パス（新規6件含む）ReslideServerEmbedがアスペクト比通りに表示されることを確認aspectRatio: 0）が従来通り動作することを確認🤖 Generated with Claude Code