Add emojis to the login page - #3
Draft
kc-beard wants to merge 1 commit into
Draft
Conversation
Adds a noodle bowl emoji to the umami heading, person/lock emojis to the username and password field labels, and a rocket emoji to the login button. Run-on: Niteshift Local Dev Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds emojis to the login page:
umamiheadingEmojis are composed inline in
LoginForm.tsxrather than baked into the translation message catalogs, so all existing localized strings are untouched and every locale picks up the emojis automatically.Verification
Ran the app locally (
pnpm devagainst a local Postgres with migrations applied) and exercised the real login flow in a browser:GET /login→200; page renders with all four emojis visible (heading, both field labels, submit button).http://localhost:3000/websiteswith the authenticated dashboard rendered. Login behavior is unchanged.<label for="_r_0_">👤 Username</label>and<label for="_r_6_">🔒 Password</label>.biome check src/app/login/LoginForm.tsx→ clean.tsc --noEmit→ no errors for the changed file.Note:
data-testhooks (input-username,input-password,button-submit) used bytests/e2e/login.spec.tsare unchanged, so the e2e selectors still resolve.🤖 Generated with Claude Code
🌒 Run on Niteshift: View Task