Skip to content

refactor: record setup per workspace instead of per person - #344

Merged
davemooreuws merged 1 commit into
mainfrom
drop-onboarding-flag
Oct 9, 2026
Merged

davemooreuws merged 1 commit into
mainfrom
drop-onboarding-flag

Conversation

@davemooreuws

@davemooreuws davemooreuws commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Setup is now recorded on the workspace (setup_completed_at), not the person. /me still carries it, as setupCompletedAt on each workspace. So this doesn't do what SUGA-1954 asked as written: the ticket assumed only /onboarding read the per-user flag, but the workspace page also read it on every load, and still needs that answer.

  • First setup and "New workspace" are now one flow at /onboarding?workspace=<slug> (previously /onboarding/new).
  • Opening an unfinished workspace sends anyone who may finish it (manageProviders) back to setup. Someone invited part way through gets the workspace as it is. If permissions fail to load, the page shows an error instead of opening the workspace.
  • / opens a workspace whose setup is finished, if there is one, rather than the last one chosen. An unfinished workspace opens when asked for by its address or the switcher.
  • Cancel deletes the workspace being set up while its setup is unfinished, if the person may delete it (its owner), including after a reload. Before, it deleted only a workspace made on the same page.
  • The name step writes ?workspace=<slug> before saving the workspace, so a reload during the save comes back to it instead of saying the name is taken.
  • Someone who already has workspaces and opens a bare /onboarding now starts setting up a new one.
  • The migration adds workspace.setup_completed_at, marks existing workspaces as set up from created_at, and drops user.onboarding_completed_at.

Closes SUGA-1954

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
sugabots-website 1fb8ac2 Oct 09 2026, 01:08 AM

@davemooreuws
davemooreuws added this pull request to stack #346 October 8, 2026 05:33
@davemooreuws
davemooreuws force-pushed the drop-onboarding-flag branch 2 times, most recently from cd561b8 to 32c55c8 Compare October 8, 2026 22:10
@davemooreuws
davemooreuws marked this pull request as draft October 8, 2026 22:45
@davemooreuws davemooreuws changed the title refactor: drop the per-user onboarding completed flag refactor: record setup per workspace instead of per person Oct 9, 2026
@davemooreuws
davemooreuws marked this pull request as ready for review October 9, 2026 01:22
@davemooreuws
davemooreuws merged commit 118fc09 into main Oct 9, 2026
7 checks passed
@davemooreuws
davemooreuws deleted the drop-onboarding-flag branch October 9, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant