Repository navigation
refactor: record setup per workspace instead of per person - #344
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
sugabots-website | 1fb8ac2 | Oct 09 2026, 01:08 AM |
davemooreuws
added this pull request to stack #346
October 8, 2026 05:33
davemooreuws
force-pushed
the
drop-onboarding-flag
branch
2 times, most recently
from
October 8, 2026 22:10
cd561b8 to
32c55c8
Compare
davemooreuws
marked this pull request as draft
October 8, 2026 22:45
davemooreuws
force-pushed
the
drop-onboarding-flag
branch
from
October 8, 2026 23:02
32c55c8 to
30710f6
Compare
davemooreuws
force-pushed
the
drop-onboarding-flag
branch
from
October 9, 2026 01:08
30710f6 to
1fb8ac2
Compare
davemooreuws
marked this pull request as ready for review
October 9, 2026 01:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup is now recorded on the workspace (
setup_completed_at), not the person./mestill carries it, assetupCompletedAton each workspace. So this doesn't do what SUGA-1954 asked as written: the ticket assumed only/onboardingread the per-user flag, but the workspace page also read it on every load, and still needs that answer./onboarding?workspace=<slug>(previously/onboarding/new).manageProviders) back to setup. Someone invited part way through gets the workspace as it is. If permissions fail to load, the page shows an error instead of opening the workspace./opens a workspace whose setup is finished, if there is one, rather than the last one chosen. An unfinished workspace opens when asked for by its address or the switcher.?workspace=<slug>before saving the workspace, so a reload during the save comes back to it instead of saying the name is taken./onboardingnow starts setting up a new one.workspace.setup_completed_at, marks existing workspaces as set up fromcreated_at, and dropsuser.onboarding_completed_at.Closes SUGA-1954