Repository navigation
fix(core): say why discovery failed - #415
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
sugabots-website | a639153 | Oct 15 2026, 06:25 AM |
Split ModelDiscoveryFailed into one DomainError class per failure, each with a message that says what to fix, and add remote.ts to the error-handling allowlist.
jyecusch
force-pushed
the
jye/discovery-failures
branch
from
October 15, 2026 06:24
23a98f4 to
a639153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery failures were one
ModelDiscoveryFailedwith vague text like "Provider returned 404" or "Connection failed". Each failure is now its ownDomainErrorclass with a message that says what to fix, andremote.tsjoins the error-handling allowlist.