Repository navigation
fix: let local sandboxes work on Docker Desktop - #417
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
sugabots-website | 366bc8f | Oct 15 2026, 06:28 AM |
davemooreuws
force-pushed
the
docker-desktop-sandboxes
branch
from
October 15, 2026 06:27
6296fc3 to
366bc8f
Compare
Member
Author
|
@jyecusch / @HomelessDinosaur could you test this on Mac? |
Member
|
Worked for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Docker Desktop the host can't reach Docker's bridge address, 172.17.0.1, which OpenSandbox put in every sandbox address it returned, so the API never reached a local sandbox.
OpenSandbox 1.1.0 takes two hosts, so
compose.ymlnow sets each to one that works everywhere:[server].eip = "127.0.0.1"is the host in the addresses returned to the API. Sandbox ports are published on0.0.0.0(hard-coded asDOCKER_PUBLISH_HOST), so they answer on loopback, and Docker Desktop forwards them to the host's loopback.[docker].host_ip = "host.docker.internal"is how the OpenSandbox container itself reaches them, for its proxy and egress readiness check. The service'sextra_hosts: host-gatewayentry resolves it on Docker Engine and Docker Desktop.publish_hostis gone: OpenSandbox'sDockerConfighas no such field and Pydantic ignores unknown keys, so it never did anything. With no setting left to choose,OPENSANDBOX_HOST_IPis gone too.The OpenSandbox tests (
sandboxes.test.ts,tools/sandbox.test.ts) pass on Docker Desktop for Windows and on Docker Engine on Ubuntu 24.04 (a temporary Actions run, removed). Docker Desktop for Mac should behave like Windows but hasn't been run.An existing OpenSandbox needs
docker compose --profile sandboxes up -d --force-recreate opensandbox: Compose doesn't recreate it when only the inline config changes.Closes SUGA-2002